import { db } from '../db/connection';
import { exec } from 'child_process';

// 用户查询服务 - 存在SQL注入漏洞
export class UserService {
  async findUserByName(username: string): Promise<any> {
    // ❌ 危险: 直接拼接SQL语句
    const query = `SELECT * FROM users WHERE name = '${username}'`;
    return db.query(query);
  }

  async exportData(format: string): Promise<void> {
    // ❌ 危险: 命令注入漏洞
    const cmd = `python export.py --format ${format}`;
    exec(cmd, (err, stdout) => {
      console.log(stdout);
    });
  }

  renderProfile(userInput: string): string {
    // ❌ 危险: XSS漏洞
    return `<div class="profile">${userInput}</div>`;
  }
}

import { db } from '../db/connection';
import { execFile } from 'child_process';
import DOMPurify from 'dompurify';

// 用户查询服务 - 已修复安全漏洞
export class UserService {
  async findUserByName(username: string): Promise<any> {
    // ✅ 安全: 使用参数化查询
    const query = 'SELECT * FROM users WHERE name = ?';
    return db.query(query, [username]);
  }

  async exportData(format: string): Promise<void> {
    // ✅ 安全: 使用白名单和execFile
    const allowedFormats = ['json', 'csv', 'xml'];
    if (!allowedFormats.includes(format)) {
      throw new Error('Invalid format');
    }
    execFile('python', ['export.py', '--format', format]);
  }

  renderProfile(userInput: string): string {
    // ✅ 安全: 输入净化和转义
    const clean = DOMPurify.sanitize(userInput);
    return `<div class="profile">${clean}</div>`;
  }
}